Skip to content

test(miner-ui): cover bare-integer portfolio-queue identifier parsing - #8772

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
philluiz2323:test/8671-bare-integer-portfolio-queue-id
Jul 26, 2026
Merged

test(miner-ui): cover bare-integer portfolio-queue identifier parsing#8772
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
philluiz2323:test/8671-bare-integer-portfolio-queue-id

Conversation

@philluiz2323

@philluiz2323 philluiz2323 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add chat-portfolio-queue-resolve.test.ts covering the bare-integer IDENTIFIER_RE arm: release acme/widgets 12 and requeue acme/widgets 12 both resolve identifier: "issue:12".
  • Negative case: release acme/widgets for sprint v2 does not treat v2 as an identifier (lookbehind/lookahead).

Closes #8671

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npx eslint src/lib/chat-portfolio-queue-resolve.test.ts (exit 0, Prettier/LF clean)
  • npx vitest run src/lib/chat-portfolio-queue-resolve.test.ts (3 passed)
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Test-only PR (apps/** excluded from codecov/patch). Dedicated resolve test file exercises the pure parser without the actions suite's ui-kit import graph.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — test-only; no visible UI change.

Notes

@philluiz2323
test(miner-ui): cover bare-integer portfolio-queue identifier parsing
29a88b3 
Add direct resolvePortfolioQueueChatAction tests for release/requeue with a trailing bare integer, plus a negative case where a digit glued to a letter (v2) is not treated as an identifier.

Closes JSONbored#8671
@philluiz2323
philluiz2323 requested a review from JSONbored as a code owner July 26, 2026 03:46
@superagent-security

superagent-security Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 26, 2026
@loopover-orb

loopover-orb Bot commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-26 03:50:56 UTC

1 file · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a focused, test-only addition covering the previously-uncovered bare-integer arm of IDENTIFIER_RE in resolvePortfolioQueueChatAction, adding three cases: two positive (release/requeue with bare integer resolving to issue:N) and one negative (digit glued to a letter like v2 not matching). The tests are self-contained, import only from the module under test, and align cleanly with the linked issue #8671. CI passed and the assertions are concrete equality checks rather than loose matchers, which is good practice for this kind of parser coverage.

Nits — 4 non-blocking
  • The inline comments duplicate context already in the PR description and test name; could be trimmed for brevity.
  • No test case for a bare integer directly adjacent to another digit-boundary edge case (e.g. trailing punctuation), though this may be out of scope for the linked issue.
  • Consider also asserting the ok:false or unmatched fallback path if IDENTIFIER_RE has other untested arms, to build toward full parser coverage in a follow-up.
  • If the actions suite already has broader coverage helpers, cross-link them in a comment for future maintainers.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8671
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 1025 registered-repo PR(s), 601 merged, 126 issue(s).
Contributor context ✅ Confirmed Gittensor contributor philluiz2323; Gittensor profile; 1025 PR(s), 126 issue(s).
Improvement ℹ️ Insufficient signal risk: clean · value: insufficient-signal · LLM: minor
Linked issue satisfaction

Addressed
The PR adds direct tests for both release and requeue bare-integer identifiers resolving to "issue:12", plus a negative test showing "v2" is not misread as an identifier due to the lookbehind/lookahead boundary, covering all three stated deliverables.

Review context
  • Author: philluiz2323
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, MDX, TypeScript, CSS, Cuda, HTML, Kotlin
  • Official Gittensor activity: 1025 PR(s), 126 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

loopover-orb[bot]
loopover-orb Bot approved these changes Jul 26, 2026
View reviewed changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit ef7e5ba into JSONbored:main Jul 26, 2026
6 checks passed
@philluiz2323 philluiz2323 mentioned this pull request Jul 26, 2026
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loopover-orb loopover-orb[bot] loopover-orb[bot] approved these changes
@JSONbored JSONbored Awaiting requested review from JSONbored JSONbored is a code owner

Assignees

@philluiz2323 philluiz2323

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test(miner-ui): chat-portfolio-queue-resolve's bare-integer identifier branch has zero test coverage

1 participant

@philluiz2323